Tony Griffin Responsive News Reader#24
Open
TonyGriffin wants to merge 2 commits intoconstructorlabs:masterfrom
Open
Tony Griffin Responsive News Reader#24TonyGriffin wants to merge 2 commits intoconstructorlabs:masterfrom
TonyGriffin wants to merge 2 commits intoconstructorlabs:masterfrom
Conversation
|
|
||
| form.addEventListener("submit", function(event) { | ||
| event.preventDefault(); | ||
| console.log(event.target["0"].value); |
Contributor
There was a problem hiding this comment.
It would be better to get the input using querySelector. It will make code more robust since it could break with indexes if HTML gets re-arranged
|
|
||
| searchForm(); | ||
|
|
||
| // let input = ""; |
Contributor
There was a problem hiding this comment.
Unused code can be deleted. Otherwise it just ends up clogging up the page
| // } | ||
|
|
||
| function displayErrorToUser(){ | ||
|
|
Contributor
There was a problem hiding this comment.
It would be great to see this implemented so user can be notified of any issues
Contributor
|
Would be great to see a README that explains what the project does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search function appears to work but unable to get it to update the page.
Too many stories displaying.
No pagination